PITS /

00690: Various corrections

Summary: Various corrections

Created: 2006-03-07 03:06

Status: Closed - fixed for 2.1.beta38

Category: Feature

From: Athan

Assigned:

Priority: 5

Version: 2.1 b36

OS: Any

Description: Proposal for various corrections in print.tmpl, XLPageTemplate and others...

1. Default print template, produce HTML 4 pages instead XHTML. Also, according to w3c validator, those pages are not valid HTML4. See validation results

2. In the same file (print.tmpl), $LastModified has to be bracketed to work with XLPage.

3. Finally two localizable string entries used in print.tmpl have to be added in XLPageTemplate.

Corrected (XHTML valid) print.tmpl follows...

<!DOCTYPE html
    PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html>
<head>
  <title>$WikiTitle | $Group / $Title</title>
  <link rel='stylesheet' href='$SkinDirUrl/print.css' type='text/css' />
  <!--HeaderText-->
</head>
<body>
  <div id='printhead'>
    <h3>$[From $WikiTitle]</h3>
    <h1 class='pagename'><a href='$ScriptUrl/$Group'>$Group: $Title</a></h1>
  </div>
<!--PageText-->
  <div id='printfoot'>
    <div class='from'>$[Retrieved from $PageUrl]</div>
    <div class='lastmod'>$[Page last modified on {$LastModified}]</div>
  </div>
</body>
</html>

I have already added the following two lines to PmWiki's XLPageTemplate and now page print preview is fully localizable and XHTML valid.

  ### Page print strings
  'From $WikiTitle' => '',
  'Retrieved from $PageUrl' => '',

I hope you consider adding these corrections in next release.

Athan

Made most of the changes listed above (on pmwiki.org, slated for beta38 release), and two more:

The Retrieved from $PageUrl really ought to be Retrieved from {$PageUrl}
The $Group and $Title should be {$Group} and {$Title}

It now validates. Any other changes?

--Pm

Thanks Patric, What about adding missing Submit Query entry in XLPageTemplate?
http://pmichaud.com/pipermail/pmwiki-users/2006-February/023810.html

Not a serious omission though :)

Athan

Entered as a new entry -- PITS:00695. --Pm