00725: UrlApproval request for additional options

Summary: UrlApproval request for additional options
Created: 2006-04-25 11:18
Status: Closed - already exists
Category: Feature
From: Axel Groll Munich
Assigned:
Priority:
Version: 2.1
OS: N/A

Description: Request for urlapproval options to (1) display urls unaltered without approval and (2) set per edit limitations instead.

*Note: This request was posted by the Axel at the end of the PmWiki.UrlApprovals. I restored the distribution documentation, relocated the request here, and added my own comments. Pico April 25, 2006, at 11:19 AM

*Second note: I reedited it again in blue. I thank Pico for the help and hope the suggestion is clear enough now. Axel, April 27, 2006, at 10:47 AM

I just included the script in my config.php and it does it's supposed job. :) Nontheless, I found a few minor additions would perhaps make it even smarter:

  • option to display unapproved links without modification/need to approve
    • Isn't that tool tip, added to the documentation in response to PIT 00446?
      See PmWiki.UrlApprovals and Test.UrlApprovals
    • Or do you want something more, like literal display of link markup used for unapproved link, or a disregard of aliases for unapproved urls?
      • Yes, the latter. I'd like to leave all unaproved links completely unaltered, visible and functional in any way. No need to check and approve them.
    This capability already exists -- simply set the value of $UnapprovedLinkFmt:
        $UnapprovedLinkFmt = '$LinkText';
    
    
  • option to limit the max. number of newly added unapproved links for each edit.
    • Isn't that $UnapprovedLinkCountMax ?
    • Or are you looking for a per edit limit?
      • Exactly. Any sane spammer or script has a list with say 100 urls he/it would like to enter once.
      • So imho, an each edit limit to newly added urls of say 3 or 4 (!) urls won't hinder a normal user slowly creating a link list. But it will stop a spammer.
        • Though, around PmWiki.org, most spam I have encountered is much closer to 3 or 4 links than higher numbers.
          • This is interesting. I repeatedly got around 200 urls on unprotected or inexistant common wiki admin pages. Finally, a new edit limit of 2 (!) unappoved urls will still work for any normal user. ;)
    PmWiki treats each post as being a "new" post in its entirety -- there's not really a good way for it to know which unapproved links are "new" in a particular edit (unless it does a lot of rendering during the edit phase).

This would enable Pmwiki to prevent any spammer or script, but keep admins clear of the need to check every single link for spam.

Thanks so much for the script and your help, Axel Groll Munich http://audi100.selbst-doku.de/

Indeed, thanks to pm and the community for the incredible well designed and neat peace of software and Pico for moving my small request to it's correct place :) Axel