• View
• Edit
• History
• Attach
• Print

00803: SearchBox function lacks XHTML 1.0 strict (XHTML 1.1) compatibility. Fix inside!

Description: The form in pagelist.php for the SearchBox function can easily be fixed to produce valid xhtml 1.0 strict / xhtml 1.1 code. The <input /> tag should be embraced by a paragraph tag.

just change l. 97 ff. from

 $out .= "<input type='text' name='q' value='{$opt['value']}' 
 class='inputbox searchbox' size='{$opt['size']}' /><input type='submit' 
 class='inputbutton searchbutton' value='{$opt['label']}' />";

to

 $out .= "<p><input type='text' name='q' value='{$opt['value']}' 
 class='inputbox searchbox' size='{$opt['size']}' /><input type='submit' 
 class='inputbutton searchbutton' value='{$opt['label']}' /></p>";

and l. 105 from

 $out .= "<input type='hidden' name='$k' value='$v' />";

to

 $out .= "<p><input type='hidden' name='$k' value='$v' /></p>";

I would love to see that in the core distribution. Do any design decisions speak against this patch?