[pmwiki-users] Shared pages recipe

Patrick R. Michaud pmichaud at pobox.com
Tue Dec 6 07:12:18 CST 2005


On Tue, Dec 06, 2005 at 11:07:48AM +0100, Dominique Faure wrote:
> 2005/12/5, Patrick R. Michaud <pmichaud at pobox.com>:
> > Any comments or improvements to the text are greatly welcomed.
> 
> Reading the code snippet you provide there, I was asking myself about
> the pagestore abstraction: why not promulgate the actual Lock function
> to a PageStore methods with the $LockFile variable as a data member?

Locking really needs to take place at a higher level than PageStore;
we need to lock the entire edit or update transaction and not just the 
writing of data into a PageStore.

It's also becomes a question of "which PageStore does the locking?"
as typically any running instance of PmWiki will have two or three
PageStores defined.  And it's important that all of the PmWiki's 
sharing a PageStore agree on the lockfile being used. 

Pm




More information about the pmwiki-users mailing list