• View
• Edit
• History
• Attach
• Print

00633: Categories are incorrectly group qualified in pagelists of trails (or filtered out entirely)

Description:

When using a category in a trail such as:

 
   page: MyGroup.FooTrail

   * [[Foo.Bar]]
   * [[Foo.MiliBar]]
   * [[!Silly]]
   ...

and trying to do a paglist on it using:

 
     (:pagelist trail=MyGroup.FooTrail:)

the category ends up getting listed as a page in the MyGroup group, as MyGroup.Silly.

Analysis:

There are two problems and they both occur in the trails.php ReadTrails() function here:

    if (!preg_match("/^([#*:]+) \\s*
          (\\[\\[([^:#!|][^|:]*?)(\\|.*?)?\\]\\]($SuffixPattern)
          | (($GroupPattern([\\/.]))?$WikiWordPattern)) (.*)/x",$x,$match))
         continue;
      if (@$match[6]) {
         if (!$LinkWikiWords) continue;
         $tgt = MakePageName($trailname,$match[6]);
      } else $tgt = MakePageName($trailname,$match[3]);

1. Categories are explicitly filtered out on the second line.
2. The $match[3] on the last line will get set to !Silly and then passed to MakePageName() which returns the wrong answer: MyGroup.Silly.

Proposed Fix:

1. Simply remove the ! on the second line and Categories will no longer be filtered.
2. I'm not sure if MakePageName() should be able to handle this correctly, but one way to intercept it before it even gets there is to add $CategoryGroup to the gloabls for the ReadTrail() function and to add this line:

A Test for this, at the bottom, the TestCategory is not even available as the next link as it should be.

In the example above this will work it the correct syntax is used

   * [[Foo.Bar]]
   * [[Foo.MiliBar]]
   * [[Category/Silly]]