• View
• Edit
• History
• Attach
• Print

01461: PHP 8

Description: PHP 8 has made a number of breaking changes, so code that previously worked fine now needs to be rewritten.

On this page we keep track of the work done and pending to update the core codebase for PHP 8.

Note: reports should be made for the nightly snapshot. If you use an older version, please upgrade first.

Pending issues

Please add new reports below this line.

When working with PHP 7.4 my installation is now completely without warnings, even on page editing with the recipe editattr.php (in conjunction with pccf2pcf.php) and on problematic pages with a lot of scripting. When moving to PHP 8.0 the following warnings occur (all on core scripts):

1. [28-Mar-2022 19:55:10 Europe/Berlin] PHP Warning: Undefined array key "postdraft" in .../scripts/draft.php on line 59
2. [28-Mar-2022 19:55:10 Europe/Berlin] PHP Warning: Undefined array key "postedit" in .../scripts/draft.php on line 59
3. [28-Mar-2022 19:55:10 Europe/Berlin] PHP Warning: Undefined array key 0 in .../scripts/markupexpr.php(111) : eval()'d code on line 1
4. [28-Mar-2022 19:55:10 Europe/Berlin] PHP Warning: Undefined array key "text" in .../scripts/notify.php on line 104
5. [28-Mar-2022 19:55:10 Europe/Berlin] PHP Warning: Undefined array key 0 in .../scripts/markupexpr.php(111) : eval()'d code on line 1

This is just to inform you for future releases. It is OK for me to work further with PHP 7.4. Siegfried Seibert March 28, 2022, at 06:12 PM

Drafts and Notify were fixed. It would again be useful to know the markup expression that causes the warning. --Petko March 29, 2022, at 08:45 AM

Should be fixed

When Upgrading to PHP 8 (with PmWiki 2.3.2) I got a lot of PHP-Warnings "Undefined array key". I fixed this in my own config.php with $FmtPV['$urlgroup'] = chkget($_GET['group'] ?? ''); (from: https://stackoverflow.com/questions/4261133/notice-undefined-variable-notice-undefined-index-warning-undefined-arr#4261200). Hope that this is right. There are still some messages from pmwiki core scripts:

Siegfried Seibert at 2022 March 26, 02:57 MEZ

Thank you for the report, very much appreciated. For the markup expression, it may be useful to tell me what expression is being evaluated in the page. "Notify" has been reported and should have been fixed in the pre-release. The others were fixed today, nevertheless I didn't see the same warnings before so in case something is not right, please let me know. A new version 2.3.3 will be released shortly. --Petko

Thanks. I just installed the new PmWiki 2.3.3. After a quick test it seems that all the warnings are gone, except Undefined array key "=protectsafe" in .../scripts/pagelist.php . Now on line 611. Siegfried Seibert March 26, 2022, at 12:24 PM

It seems that there ist still a warning from notify.php: PHP Warning: Undefined array key "text" in .../scripts/notify.php on line 104 Siegfried Seibert March 26, 2022, at 12:44 PM

Unfortunately I still cannot experience this -- I suspect your configuration has some differences from mine. I made another change that should silence it, you can get the partial export from PmWiki:ChangeLog (only pagelist.php changed) and please report if it was fixed. --Petko March 26, 2022, at 02:38 PM

Thank You, I tried the modified pagelist.php and the warning disappeared on the pages where they formerly occurred. But when I understand your message right, this only silenced the warning but did not solve the problem itself, which may come from my configuration. So I still have to check my configuration? I still have some other warnings concerning Custom Markup Expressions, which I will have to check during the next few days too. Once again thank you very much. Siegfried Seibert March 26, 2022, at 05:10 PM

The change I made makes it behave like before PHP 8, that is, an undefined variable will be cast to an empty array, so I would not worry about it anymore. Actually I believed the other change I made in that function would already do this, but apparently in some cases it didn't. For custom markup expressions, or for other variables or array elements that raise warnings, my current solution is to explicitly cast them to the expected types with intval(@$var), floatval(@$var), strval(@$var), or (array)@$var. PmWiki was designed to work this way, forgiving things that are not completely defined, and assuming 0, array(), or "" (empty string). The Null coalesce operator ?? is great but requires PHP 7, and we still want to keep PmWiki PHP 5.5 compatible.

We should probably write some helper functions to help with this, but it looks daunting. The main difficulty to make the same code work for old and new PHP versions is that the "undefined" thing may be a variable (of several types), an array or it can be a missing key to an existing array, and all these would be treated differently in PHP 5. For the moment it seems to me easier/clearer to just use intval/strval/etc. --Petko March 26, 2022, at 05:36 PM

Closed issues

  if ($auth['htgroup'] ??= NULL) {

Index: scripts/authuser.php
===================================================================
--- scripts/authuser.php	(revision 3719)
+++ scripts/authuser.php	(working copy)
@@ -70,6 +70,7 @@
     }
   }

+  $authlist = array();
   if (func_num_args()==2) $authid = $id;
   else
     foreach($AuthUserFunctions as $k => $fn) 
@@ -86,7 +87,7 @@
     $authlist[$g] = 1;
   foreach(preg_grep('/^@/', array_keys($auth)) as $g) # useless? PITS:01201
     if (in_array($authid, $auth[$g])) $authlist[$g] = 1;
-  if ($auth['htgroup']) {
+  if (@$auth['htgroup']) {
     foreach(AuthUserHtGroup($pagename, $id, $pw, $auth['htgroup']) as $g)
       $authlist["@$g"] = 1;
   }

  Warning: Undefined array key "EximCfgMain" in /home/www/pmwiki/scripts/wikiwords.php on line 66

  if ($depth == 0) $depth = strlen($depth);
  if ($icol == 0) $icol = strlen($icol);

  if (!is_numeric($depth)) $depth = strlen($depth);
  if (!is_numeric($icol)) $icol = strlen($icol);